Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] DashboardScene: Fixes panel edit issue with clearing title not resulting in hover header mode #85633

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[v11.0.x] DashboardScene: Fixes panel edit issue with clearing title not resulting in hover header mode #85633

merged 1 commit into from
Apr 5, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 49a3a95 from #85621

Could not find a bug report for this.

  • Update hoverHeader when changing title
  • Could also not find any unit tests for panel options (like we have for old panel edit) so made a first stab at that.
  • Also moved the getPanelFrameCategory2 from the old panel editor file to scene panel edit folder & file.
  • Removed duplicate test for library panel options (at least I could not see any difference)

@torkelo @grafana-delivery-bot
DashboardScene: Fixes panel edit issue with clearing title not result…
7903601 
…ing in hover header mode (#85621)

* PanelEditor: Update hoverHeader state when changing panel title

* refactor test and remove duplicate

(cherry picked from commit 49a3a95)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner April 5, 2024 09:30
@grafana-delivery-bot grafana-delivery-bot bot requested review from ivanortegaalba and removed request for a team April 5, 2024 09:30
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 5, 2024
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes type/bug labels Apr 5, 2024
@torkelo torkelo merged commit 576a7e4 into v11.0.x Apr 5, 2024
22 checks passed
@torkelo torkelo deleted the backport-85621-to-v11.0.x branch April 5, 2024 11:06
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

@mdvictor mdvictor Awaiting requested review from mdvictor mdvictor is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torkelo @fabrizio-grafana