Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] Grafana E2E: Add deprecation notice and update docs #85778

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 0f1b65a from #85619


What is this feature?

By the time G11 is released, @grafana/plugin-e2e will be generally available so we should deprecate the @grafana/e2e package. The plan for phasing out grafana/e2e is as follows:

  1. Before Grafana 11.0.0 is released: Add deprecation notice in the grafana/e2e readme and update all docs referring to grafana/e2e
  2. After Grafana 11.0.0 is released: Deprecate the package in NPM
  3. Before Grafana 11.1.0 is released: Delete the grafana/e2e package code entirely from the Grafana repo

This PR adds a deprecation notice and updates docs (step 1). This change will be communicated in the changelog, the release notes, community slack and (likely) in a blog post.

The style guide has three articles covering e2e testing - e2e.md, e2e-core.md and e2e-plugins.md. The e2e-plugins.md is now updated with relevant info. I made a few minor changes to the e2e and e2e-core docs, but feels like there are still a few things that are irrelevant, so it probably needs to be looked into by someone from the frontend platform. Pinging @ashharrison90 since I know you were involved in the migration from Cypress 9.

Who is this feature for?

Plugin authors

Which issue(s) does this PR fix?:

Part of #77484

Fixes #85625

Release notice breaking change

The @grafana/e2e package is deprecated in Grafana 11.0.0. If your Grafana plugin has end-to-end tests that use @grafana/e2e, it's recommended to replace them with @grafana/plugin-e2e and Playwright. For information on how to migrate, please refer to the plugin-e2e docs.

* add deprecation notice

* update docs

* Update packages/grafana-e2e/README.md

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>

---------

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
(cherry picked from commit 0f1b65a)
@grafana-delivery-bot grafana-delivery-bot bot requested review from a team as code owners April 9, 2024 08:11
@grafana-delivery-bot grafana-delivery-bot bot requested review from Clarity-89 and JoaoSilvaGrafana and removed request for a team April 9, 2024 08:11
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 9, 2024
@grafana-delivery-bot grafana-delivery-bot bot requested review from moxious and tonypowa and removed request for a team April 9, 2024 08:11
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/frontend backport A backport PR breaking change Relevant for changelog generation product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs labels Apr 9, 2024
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sunker sunker merged commit ee8bb9e into v11.0.x Apr 9, 2024
23 checks passed
@sunker sunker deleted the backport-85619-to-v11.0.x branch April 9, 2024 09:02
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend backport A backport PR breaking change Relevant for changelog generation product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants