Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] Time Zones: Fix relative time when using UTC timezone #85779

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[v11.0.x] Time Zones: Fix relative time when using UTC timezone #85779

merged 1 commit into from
Apr 9, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 4b5b738 from #85637

What is this feature?

  • updates the time zone e2e test to explicitly test the UTC timezone as well
  • removes a special case block for UTC and instead lets it pass through to moment.tz as all the other timezones do

Why do we need this feature?

  • to ensure relative time in the UTC time zone works correctly

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 @grafana-delivery-bot
Time Zones: Fix relative time when using UTC timezone (#85637)
2879136 
add UTC case to e2e test + let UTC pass through to moment.tz

(cherry picked from commit 4b5b738)
@grafana-delivery-bot grafana-delivery-bot bot requested review from a team as code owners April 9, 2024 08:56
@grafana-delivery-bot grafana-delivery-bot bot removed the request for review from a team April 9, 2024 08:56
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 9, 2024
@grafana-delivery-bot grafana-delivery-bot bot removed the request for review from a team April 9, 2024 08:56
ashharrison90
ashharrison90 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 enabled auto-merge (squash) April 9, 2024 08:56
@ashharrison90 ashharrison90 merged commit d56f75e into v11.0.x Apr 9, 2024
21 checks passed
@ashharrison90 ashharrison90 deleted the backport-85637-to-v11.0.x branch April 9, 2024 09:12
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@jackw jackw Awaiting requested review from jackw jackw is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR type/bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashharrison90 @fabrizio-grafana