[v11.0.x] Alerting: Fix evaluation metrics to not count retries #86059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* Change evaluation metrics to only count once per eval, and add new metrics. * Cosmetic: Move eval total Inc() to orginal place. (cherry picked from commit ad7f804)
grafana-delivery-bot
bot
requested review from
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/backend
backport
stevesg
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ad7f804 from #85873
Changes the following metrics to scope multiple retry attempts as a single occurrence:
grafana_alerting_rule_evaluation_duration_secondsgrafana_alerting_rule_evaluations_totalgrafana_alerting_rule_evaluation_failures_totalThe benefits are:
The change also adds the following new metrics, which inherit the behavior of the previous metrics.
grafana_alerting_rule_evaluation_attempts_totalgrafana_alerting_rule_evaluation_attempt_failures_totalI've opted not to add a duration for individual attempts, I don't think it's worth the additional cardinality, and the information is available through debug log lines if needed.
Fixes #85847