[v11.0.x] Table Panel: Fix image disappearing when datalinks applied #86160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* Fix link image disappearing * Prettier * i18n * Fix offset to compensate for padding * Prettier --------- Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 154868e)
grafana-delivery-bot
bot
requested review from
codeincarnate
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/frontend
area/panel/table
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 154868e from #84625
What is this feature?
When using the image cell with a datalink and hovering over the image the image would disappear because no absolute width or height is applied. This makes the link functionally have zero width and height making it so it's no displayed. This PR sets the height of the link to the height of the cell (minus 2px).
With old styles container width would be sufficient for this, but with height now changing with hover for text wrapping this no longer works in the intended way.
Why do we need this feature?
Prevents images from disappearing on hover.
Before:
Screen.Recording.2024-03-16.at.2.46.31.PM.mov
After:
Screen.Recording.2024-03-16.at.2.44.18.PM.mov
Please check that: