Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] Datasources: Add fixed width to name field in config editor #86179

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 28ecd83 from #84970


What is this feature?

By fixating the width of this field, we at least give data sources a chance to align label width in the fields used in the config editor so that it looks better.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

add fixed width to name field

(cherry picked from commit 28ecd83)
@grafana-delivery-bot grafana-delivery-bot bot requested review from mikkancso and a team as code owners April 15, 2024 14:51
@grafana-delivery-bot grafana-delivery-bot bot requested review from oshirohugo and removed request for a team April 15, 2024 14:51
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 15, 2024
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/frontend backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported labels Apr 15, 2024
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 merged commit 3aba1ad into v11.0.x Apr 15, 2024
21 checks passed
@ashharrison90 ashharrison90 deleted the backport-84970-to-v11.0.x branch April 15, 2024 15:10
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants