[v11.0.x] Alerting: Reduce set of fields that could trigger alert state change #86266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/alerting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6f38ac6 from #83496
What is this feature?
We want to avoid too much change of alert state based on change on alert's fields. For that we ignore some fields from the diff.
This is a rather cautious first pull request,
but I would love to make another pull request for. We could even go further as pointed by @yuri-tceretian but I can do in another PR.IntervalSecondsWhy do we need this feature?
There is great issue by @yuri-tceretian that detail all fo this #83250
Who is this feature for?
Everyone who use alerting and updates.
Which issue(s) does this PR fix?:
Fixes #83250
cc @yuri-tceretian