Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] Dashboard: DashboardPageProxy - Use chaining operators to prevent runtime error #86536

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[v11.0.x] Dashboard: DashboardPageProxy - Use chaining operators to prevent runtime error #86536

merged 1 commit into from
Apr 18, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 7a147f2 from #86507

Fixes undefined runtime error when dashboard or uid did not exist

TypeError: l.value.dashboard is undefined
    ir DashboardPageProxy.tsx:49
    React 8
    x scheduler.production.min.js:13
    D scheduler.production.min.js:14
    7463 scheduler.production.min.js:14
    Webpack 27
instrumentation.js:23:42
    e instrumentation.js:23
    e instrumentation.js:23
    React 9
    x scheduler.production.min.js:13
    D scheduler.production.min.js:14
    (Async: EventHandlerNonNull)
    7463 scheduler.production.min.js:14

Notes from research:

The issue surfaced because the redirect to the home-cloud-app was not happening when clicking the logo(This error surfaced because of this refactor PR) .
I tested on the ephemeral instance https://ephemeral1511182186507axelava.grafana-dev.net/ and is working now.

@axelavargas @grafana-delivery-bot
Dashboard: DashboardPageProxy - Use chaining operators to prevent run…
2ea3ad9 
…time error (#86507)

* Use chaining operators to prevent runtime error

* Fix tests

---------

Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
(cherry picked from commit 7a147f2)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner April 18, 2024 15:16
@grafana-delivery-bot grafana-delivery-bot bot requested review from bfmatei and mdvictor and removed request for a team April 18, 2024 15:16
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 18, 2024
@axelavargas axelavargas enabled auto-merge (squash) April 18, 2024 15:18
@axelavargas axelavargas merged commit d05587b into v11.0.x Apr 18, 2024
20 checks passed
@axelavargas axelavargas deleted the backport-86507-to-v11.0.x branch April 18, 2024 15:32
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelavargas axelavargas axelavargas approved these changes

@bfmatei bfmatei Awaiting requested review from bfmatei bfmatei is a code owner automatically assigned from grafana/dashboards-squad

@mdvictor mdvictor Awaiting requested review from mdvictor mdvictor is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR type/bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axelavargas @fabrizio-grafana