Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] Alerting: Take receivers into account when custom grouping Alertmanager groups #86699

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[v11.0.x] Alerting: Take receivers into account when custom grouping Alertmanager groups #86699

merged 1 commit into from
Apr 22, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport acd3e83 from #86127

What is this feature?
This PR fixes custom grouping behavior for Alertmanager alert groups
It unified how groups are display for custom and default grouping modes

Why do we need this feature?
Users are confused seeing duplicated alerts

Who is this feature for?
All users

Special notes for your reviewer:

BEFORE
image

AFTER
image

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@konrad147 @grafana-delivery-bot
Alerting: Take receivers into account when custom grouping Alertmanag…
996b421 
…er groups (#86127)

* Take receiver into account when custom grouping Alertmanager alert groups

* Fix and add tests

(cherry picked from commit acd3e83)
@grafana-delivery-bot grafana-delivery-bot bot requested review from a team as code owners April 22, 2024 14:24
@grafana-delivery-bot grafana-delivery-bot bot removed the request for review from a team April 22, 2024 14:24
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 22, 2024
@konrad147 konrad147 merged commit 3b71eab into v11.0.x Apr 22, 2024
24 checks passed
@konrad147 konrad147 deleted the backport-86127-to-v11.0.x branch April 22, 2024 14:39
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad147 konrad147 konrad147 approved these changes

@gillesdemey gillesdemey Awaiting requested review from gillesdemey gillesdemey is a code owner automatically assigned from grafana/alerting-frontend

@tomratcliffe tomratcliffe Awaiting requested review from tomratcliffe tomratcliffe is a code owner automatically assigned from grafana/alerting-frontend

@soniaAguilarPeiron soniaAguilarPeiron Awaiting requested review from soniaAguilarPeiron soniaAguilarPeiron is a code owner automatically assigned from grafana/alerting-frontend

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/frontend backport A backport PR type/bug
Projects
Alerting
Archived in project
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@konrad147 @fabrizio-grafana