Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated layout components: get rid of Layout.tsx including HorizontalGroup and VerticalGroup #86869

Closed
2 tasks done
eledobleefe opened this issue Apr 24, 2024 · 0 comments · Fixed by #86995
Closed
2 tasks done

Comments

@eledobleefe
Copy link
Contributor

eledobleefe commented Apr 24, 2024

What is the chore?:
The grafana-frontend-platform squad has created a 'non-roadmap' epic to remove the usage of the deprecated layout components: Layout, HorizontalGroup and VerticalGroup.

Is there anything else we need to know?:

  • This is a side project. No prioritization. Just keep in mind when there are downtimes, or you need a break and work on something less complicated.
  • In most cases, you just will need to:

Replace HorizontalGroup

<HorizontalGroup spacing="lg">
...
</HorizontalGroup>

with Stack

<Stack gap={3}>
...
</Stack>

or replace VerticalGroup

<VerticalGroup spacing="md">
...
</VerticalGroup>

with Stack using direction

<Stack direction="column" gap={2}>
...
</Stack>

List of issues

Remove HorizontalGroup

  • public/app/plugins/datasource/loki/components/LokiLabelBrowser.tsx
  • public/app/plugins/datasource/loki/querybuilder/components/LokiQueryCodeEditor.tsx

Thanks in advance for your collab! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants