[v11.0.x] DateTimePicker: Alternate timezones now behave correctly #87041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add failing tests for timezone handling * Fix `DateTimePicker.tsx` timezone handling - Resolves `onBlur` issue - Resolve Calendar and TimeOfDay issues - Update test to cover different timezone * Handle `console.warn` in test * Handle `console.warn` in test #2 * Better handling of invalid date When parsing date string with `dateTime`, adding a second `formatInput` aids in both parsing the actual string and avoid `console.warn` when `moment` reverts to be using `Date`. * add more test cases * Ash/proposed changes (#86854) * simplify * only need this change * formatting * const > let * add test to ensure calendar is always showing the matching day * separate state * undo story changes * update util function comments * fix for selecting date in the calendar --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> (cherry picked from commit 7fab894)
ashharrison90
added
type/bug
area/frontend
add to changelog
area/grafana/ui
ashharrison90
requested review from
joshhunt,
JoaoSilvaGrafana and
sunker
and removed request for
a team
joshhunt
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7fab894 from #86750
What is this feature?
It's a bugfix for the timezone issue with the
DateTimePickerWhy do we need this feature?
Currently, users that have one timezone in Grafana (
bootData) and another on in their client/browser, cannot use theDateTimePickeras it changes the dateonBluras well as showing invalid date/time information in date/time modal.Who is this feature for?
Developers who wants to use
DateTimePickeras well as users that already are interacting withDateTimePickerin published pluginsWhich issue(s) does this PR fix?:
86305
Fixes #86305
Special notes for your reviewer:
setTimeZoneResolverneeds to be used to change timezone.There are notes in #86305 how you could do this.
I just added the blow snippe to
DateTimePicker.story.tsx:Please check that: