Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph: Bring back diff scale legend #87314

Closed
Rperry2174 opened this issue Dec 12, 2023 · 0 comments · Fixed by #87319
Closed

Flamegraph: Bring back diff scale legend #87314

Rperry2174 opened this issue Dec 12, 2023 · 0 comments · Fixed by #87319

Comments

@Rperry2174
Copy link
Contributor

Rperry2174 commented Dec 12, 2023

In the old flamegraph we had a scale that helped users understand that the diff view is slightly inverted (red is positive numbers and green is negative) numbers which is counter-intuitive.

image

https://flamegraph.com/share/793cd196-9835-11ee-9a0d-f2c25703e557

I was doing a demo with someone from the community today and they were really caught up on this. We should bring this back so that users understand that

  • "green === negative / decrease (numerically) === good / better"
  • "red === postive (numerically) / increase === bad / worse"

Same goes for the colorblind color pallette -- without a legend it's unclear what the colors mean here
image

cc @darrenjaneczek

@aocenas aocenas transferred this issue from grafana/pyroscope May 3, 2024
@aocenas aocenas changed the title [ Flamegraph ] Bring back diff scale legend Flamegraph: Bring back diff scale legend May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants