[v11.0.x] Loki: Fix log context when no label types are present #87600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
(cherry picked from commit 1c8a77a)
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
svennergr
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1c8a77a from #87587
What is this feature?
LogContext uses the
labelTypesdata frame field to determine if a label should be used in a streamselector or as a label filter expression. When thelabelTypesfield is not present, we incorrectly assumed all labels are "non indexed" and we would use all labels as label filter expressions.This PR fixes the behavior. If the label type can not be determined, the label will be used as an indexed label and thus in the stream selector.