Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.4.x] BrowseDashboards: Prepend subpath to New Browse Dashboard actions #89129

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport c58d09f from #89109


Fixes an issue where the New Dashboard and Import buttons on Browse Dashboards wouldn't link correctly if serving Grafana from the /dashboards subpath.

As I mentioned in #84992 (review), this is mainly only a problem when Grafana is served from a subpath which conflicts with a prefix of the application URL - e.g. /dashboards. Automatic subpath-ing/react-router breaks down in this scenario.

Fixes #80777

Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job robot!

@joshhunt joshhunt merged commit 98b4404 into v10.4.x Jun 13, 2024
22 checks passed
@joshhunt joshhunt deleted the backport-89109-to-v10.4.x branch June 13, 2024 08:59
@mdvictor mdvictor modified the milestones: 10.4.x, 10.4.4 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants