Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]: Improve dashboard grid migration #9888

Closed
torkelo opened this issue Nov 15, 2017 · 0 comments
Closed

[v5]: Improve dashboard grid migration #9888

torkelo opened this issue Nov 15, 2017 · 0 comments
Assignees
Milestone

Comments

@torkelo
Copy link
Member

torkelo commented Nov 15, 2017

Migration code:
https://github.com/grafana/grafana/blob/develop/public/app/features/dashboard/dashboard_model.ts#L915

New grid system works like this, each panels is in a single array on the dashboard model. Each panel has a gridPos {x, y, w, h} these are in grid dimensions (width is 24 columns wide).

  • Try the schema migration for many dashboards and identify issues and fix or improve the migration (might need to look at panel height as well). Ignore dashboards with panel/row repeats for now.

  • Currently rows are ignored (or all rows are merged), need to detect if rows are used in the dashboard we import. And by used I mean if the row title is shown or if a row is collapsed. If either of those is true then add "row" panels to the dashboard.panels array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants