Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Adding links to graph panel #192

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Conversation

enrichman
Copy link
Contributor

Added links to graph_panel.
I've followed the same approach of the singlestat, instead of the addLink of the #165.
I've also opened a new PR because that one seemed to be stale, and I need this functionality!

Copy link

@panyushov panyushov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing

@enrichman
Copy link
Contributor Author

Hm, I'm not sure why.
I've tried manually to run the test with a jsonnet -J . tests/graph_panel/test.jsonnet > tests/graph_panel/out.json and the out.json file show no diff from the compiled.

Any help from the maintainers?

@enrichman
Copy link
Contributor Author

The test was ok, but the formatting was wrong:

Formatting ./tests/graph_panel/test.jsonnet... NOK

Fixed with a jsonnetfmt 😄

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trotttrotttrott trotttrotttrott merged commit 5281370 into grafana:master Mar 16, 2020
@enrichman enrichman deleted the graph-links branch March 16, 2020 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants