refactor(base): veneer, type derivation and missing schema's #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/restructure_veneer
branch
from
4e03465
to
2c5a451
Compare
|
rebased. |
malcolmholmes
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review tip: each commit can be reviewed separately.
refactor(base): take functional approach to adding veneer
The veneer was set up to squash everything on top, this functional approach takes a more
rigorous approach by injecting the veneer closer to the initialization of the original
code.
refactor(base): use schema.info.title to derive type
Previously the panel type schema's were characterized by PanelOptions and PanelFieldConfig
fields, these will change in the near future. Turns out deriving the type from the name is
equally consistent, I don't know why I didn't do that initially.
fix(base): provide backfilling of missing schemas
The referenced schema's are in fact empty and part of the
skipPluginslist in Grafana,newer version rendered by Grok will not include these schema's regardless of the
skipPluginsentry. This commit adds a bit of code that adds the missing plugins witha generic schema so Grafonnet can keep feature parity with previous versions.