Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Diff Output For New Dashboards #167

Closed
keithherron opened this issue Aug 31, 2021 · 3 comments
Closed

Improve Diff Output For New Dashboards #167

keithherron opened this issue Aug 31, 2021 · 3 comments

Comments

@keithherron
Copy link

Currently when running grr diff with a new dashboard that hasn't been applied to Grafana yet, I'm seeing:

Dashboard/dashboard_name not present in Dashboard

I wasn't entirely sure at first what this meant or if it was good or bad, but AIUI it means the dashboard doesn't exist yet in Grafana, so no diff is being shown.

I think this could be easier to understand if the diff for a new dashboard output something to the effect of:

Dashboard/dashboard_name changes detected (create dashboard)

Ideally with the option to print a full diff containing the new dashboard json that would be applied.

@malcolmholmes
Copy link
Collaborator

The main issue I have with the message you mention above is that "Dashboard" isn't a place where a dashboard exists - Grafana is the place where a dashboard exists. I need to add the concept of "system" so the message becomes:

Dashboard/dashboard_uid not present in Grafana

Would that do it?

@malcolmholmes
Copy link
Collaborator

malcolmholmes commented Sep 24, 2021

Actually, please try the latest release of Grizzly. This has changed a lot. I'd like to think it is much cleaner now.

@malcolmholmes
Copy link
Collaborator

Closing. Please reopen if still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants