Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using grr diff from a pull point-of-view? #243

Open
samlaf opened this issue Apr 28, 2023 · 1 comment
Open

Using grr diff from a pull point-of-view? #243

samlaf opened this issue Apr 28, 2023 · 1 comment

Comments

@samlaf
Copy link

samlaf commented Apr 28, 2023

Is there a way to use grr diff from a pull point of view?
It seems grizzly is built around making local changes to dashboards and pushing them to grafana, so the grr diff command only shows diffs to files that exist locally.
However we mostly use it for pulling down (automatically via github actions) changes that were made on the UI manually.
When creating new files on the UI, grr diff doesn't see them.
Would it be possible to change this functionality? Or add a flag for this workflow?

@malcolmholmes
Copy link
Collaborator

Can you explain further what should be diffed against what? If you make changes via the UI, what resource should that be compared to?

Also, check out the new (not yet released) serve function. This will allow you to edit dashboards that are stored in Git, but using an actual browser window to do the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants