Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] improved har typings #110

Merged
merged 3 commits into from
Oct 18, 2022
Merged

[chore] improved har typings #110

merged 3 commits into from
Oct 18, 2022

Conversation

allansson
Copy link
Contributor

These changes greatly improves the HAR-typings included in this package, fixing some inconsistencies. It includes both our extended and the standard specification. Cherry on top is that I added JSDoc comments to it, so we won't have to look up the spec. all the time.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

Copy link

@2Steaks 2Steaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 It looks amazing!

@allansson allansson merged commit ab2c65a into master Oct 18, 2022
@allansson allansson deleted the chore/improve-har-typings branch October 18, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants