Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Update git actions #127

Merged
merged 10 commits into from
Oct 6, 2023
Merged

[fix] Update git actions #127

merged 10 commits into from
Oct 6, 2023

Conversation

w1kman
Copy link
Contributor

@w1kman w1kman commented Oct 6, 2023 •
edited

  • Update actions in ci.yml
  • Bump node version from 12 => 16
  • Switch from yarn to npm
  • Replace loadimpact/har-to-k6 with grafana/har-to-k6 in package.json
  • Update package.json~engines.node
  • Bump "unsafe" packages
  • Update Release workflow
    • Automatic npm publish
    • Automatic GH release creation

@w1kman
[fix] Update git actions
b335101 
- Update actions in `ci.yml`
- Bump node version from 12 => 16
- Switch from `yarn` to `npm`
- Replace `loadimpact/har-to-k6` with `grafana/har-to-k6` in `package.json`
- Update `package.json~engines.node`
- Bump "unsafe" packages
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@w1kman w1kman marked this pull request as ready for review October 6, 2023 06:54
@w1kman w1kman requested a review from a team as a code owner October 6, 2023 06:54
@w1kman w1kman requested review from ckbedwell, EdvinasDaugirdas and e-fisher and removed request for a team and EdvinasDaugirdas October 6, 2023 06:54
allansson
allansson approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@allansson allansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

e-fisher
e-fisher approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason npm run test fails for me locally with TypeError: process.stderr.hasColors is not a function, but since it works in CI, it must be an issue with my machine.

LGTM! 🚀

@w1kman
Copy link
Contributor Author

w1kman commented Oct 6, 2023

For some reason npm run test fails for me locally with TypeError: process.stderr.hasColors is not a function, but since it works in CI, it must be an issue with my machine.

LGTM! 🚀

Nice catch! It behaved the same in CI, just didnt count as "fail".
I've pushed the least amount of changes I could to make tests run locally.

@w1kman w1kman assigned w1kman and ckbedwell and unassigned ckbedwell and w1kman Oct 6, 2023
e-fisher
e-fisher approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now! 💯

@w1kman w1kman merged commit f8d480a into master Oct 6, 2023
2 checks passed
@w1kman w1kman deleted the chore/fix-gh-actions branch October 6, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-fisher e-fisher e-fisher approved these changes

@ckbedwell ckbedwell Awaiting requested review from ckbedwell ckbedwell is a code owner automatically assigned from grafana/k6-frontend

@allansson allansson Awaiting requested review from allansson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@w1kman @CLAassistant @allansson @e-fisher @ckbedwell