Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type definitions #135

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: type definitions #135

merged 2 commits into from
Nov 3, 2023

Conversation

sumimakito
Copy link
Contributor

@sumimakito sumimakito commented Oct 7, 2023 •
edited

This pull request:

  • Renames the field pageRef under the Entry interface to pageref to keep it consistent with other occurrences in the codebase as well as the W3C specification (although it is still a draft)
  • Creates an ExtendedPage interface and adds the missing sleep field

@sumimakito sumimakito requested a review from a team as a code owner October 7, 2023 06:50
@sumimakito sumimakito requested review from 2Steaks and maroparo and removed request for a team October 7, 2023 06:50
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@sumimakito sumimakito changed the title fix: type definition of pageref in Entry fix: type definitions Oct 7, 2023
@sumimakito sumimakito force-pushed the fix/typing-entry branch 2 times, most recently from af5e63d to fda3460 Compare October 7, 2023 10:24
allansson
allansson approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@allansson allansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 👍

@allansson allansson merged commit c0022fb into grafana:master Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allansson allansson allansson approved these changes

@2Steaks 2Steaks Awaiting requested review from 2Steaks 2Steaks is a code owner automatically assigned from grafana/k6-frontend

@maroparo maroparo Awaiting requested review from maroparo maroparo is a code owner automatically assigned from grafana/k6-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sumimakito @CLAassistant @allansson