[chore] Update node to fix docker image vulnerabilities #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add possibility to output to stdout, instead of just file - Update webpack - Add `--stdout` option
w1kman
commented
Oct 12, 2023
| @@ -7,4 +7,4 @@ COPY . . | |||
| RUN npm install | |||
| RUN npm run bundle | |||
|
|
|||
| ENTRYPOINT ["node", "bin/har-to-k6.js"] | |||
| ENTRYPOINT ["node", "bin/har-to-k6.js", "--stdout"] | |||
There was a problem hiding this comment.
If the user would add option -o, --output <filename>, output would not be sent to stdout
Comment on lines
+7
to
+11
| resolve: { | ||
| fallback: { | ||
| fs: false, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Change required when updating webpack
w1kman
requested review from
allansson and
e-fisher
and removed request for
a team
w1kman
changed the title
allansson
approved these changes
Oct 12, 2023
Comment on lines
+59
to
+61
| "webpack": "^5.88.2", | ||
| "webpack-bundle-analyzer": "^4.9.1", | ||
| "webpack-cli": "^5.1.4" |
There was a problem hiding this comment.
Why you no change to parceljs? 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix vulnerabilities inherited by
node:16-slimimage.v16 => v18-s, --stdoutso that docker image can be used without mounting a volume--stdoutREADME.mdto include docker usageHow to test
README.mddocker build --tag har-to-k6:local .docker run har-to-k6:local ./example/inconsistent-content-type.har > loadtest.jsloadtest.jsfile on the host systemdocker run har-to-k6:local -o loadtest.js ./example/inconsistent-content-type.harloadtest.jsfile inside the container (old default)../bin/har-to-k6with-stdoutand--outputin different combinations to make sure that we get a desired result