Feature/add websocket functionallity #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinatafoya
requested review from
2Steaks and
ckbedwell
and removed request for
a team
|
|
trinatafoya
force-pushed
the
feature/add_websocket_functionallity
branch
2 times, most recently
from
3547ed0
to
acfb789
Compare
trinatafoya
force-pushed
the
feature/add_websocket_functionallity
branch
from
acfb789
to
2e53cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a feature that allows the
har-to-k6converter to handle web-socket functionality. It uses the k6 libraryimport ws from 'k6/ws'. These requests were formerly ignored in the original itteration ofhar-to-k6.Type of change
This version handles the websocket
send(...)messages and adds asetTimeoutin place ofsleepfor websockets, this is because k6 websocket callbacks are not made to work with thesleep(...)function.