Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conversion a little more forgiving #51

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Make conversion a little more forgiving #51

merged 1 commit into from
Aug 28, 2020

Conversation

legander
Copy link
Collaborator

  • Incoming postData param with empty names are discarded with a warning log message.
  • Dropping text with a warning log if both postData text and params are specified and are conflicting.

allansson
allansson approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@allansson allansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@legander
Copy link
Collaborator Author

It would be nice for these warnings to reach the result in the case of usage in the browser 🤔 Has to be a later improvement though..

@legander legander merged commit 2fcfa72 into master Aug 28, 2020
@legander legander deleted the fix/lax-the-validation branch August 28, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allansson allansson allansson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legander @allansson