Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add --only option to cli #55

Closed
wants to merge 3 commits into from

Conversation

bryanlarsen
Copy link

Add --only option to cli, with same behaviour as k6 convert --only

Bryan Larsen added 3 commits September 29, 2020 15:26
Add --only option to cli, with same behaviour as k6 convert --only
@legander
Copy link
Collaborator

legander commented Feb 11, 2021

Hello @bryanlarsen, thank you for wanting to contribute.
Sorry for taking ages to respond..

We have been discussing this --only option and have concluded that we do want to add support for it but with following requirements:

  • The CLI option should be forwarded to src/convert.js and filtering be done as a first step in the covert function instead of in the CLI layer. The reasoning being that any options that can modify the result should be passable programmatically as well to support integration usage and not only CLI.
  • Naming of --only is TBD, perhaps --include is better.
  • Multiple values should be specified by stacking options rather than being comma separated.
--include test.k6.io,test-api.k6.io
# becomes
--include test.k6.io --include test-api.k6.io

You are most welcome to continue with the implementation, if so please let me know.

@bryanlarsen
Copy link
Author

Thanks, but we realized that the "right" way to use har-to-k6 is to transform the har file using a jq or javascript script before passing it to har-to-k6 so would no longer need nor dogfood this option.

@legander
Copy link
Collaborator

Ah okey cool! Are you using the programmatic usage then?
Out of curiosity, how are you using har-to-k6 and in what step of the development process? If you even can or want to share that information.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bryan Larsen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@EdvinasDaugirdas
Copy link
Contributor

This is not going to be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants