Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Don't re-encode POST data unless it is necessary #57

Closed
wants to merge 1 commit into from
Closed

[fix] Don't re-encode POST data unless it is necessary #57

wants to merge 1 commit into from

Conversation

bryanlarsen
Copy link

If postData contains the posted text, preferentially use it instead of re-encoding the formData from postData.params.

Created as a partial fix for #56

[fix] Don't re-encode POST data unless it is necessary
0e359b7 
If postData contains the posted text, preferentially use it instead of re-encoding the formData from postData.params.

Created as a partial fix for grafana#56
@legander
Copy link
Collaborator

legander commented Oct 5, 2020

@bryanlarsen
The rationale for preferring params over text is that it is easier to serialize/deserialize, take a look at this closed issue #14.
Regarding the issue #56, there is a plan to refactor the multipart construction part in the converter.

@legander legander closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryanlarsen @legander