Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Query string params double inclusion #64

Merged
merged 9 commits into from
Dec 7, 2020
Merged

[fix] Query string params double inclusion #64

merged 9 commits into from
Dec 7, 2020

Conversation

w1kman
Copy link
Contributor

@w1kman w1kman commented Dec 4, 2020

Instead of blindly adding all query string params, only value pairs that are not already in the request are added.

  • URI encoded params will NOT become double encoded
  • Request protocol can be a variable again (bug found while fixing double inclusion)

Fixes issue #58

@w1kman w1kman marked this pull request as draft December 4, 2020 13:26
@w1kman
Copy link
Contributor Author

w1kman commented Dec 4, 2020

There is still some cleaning up to do.

@w1kman w1kman marked this pull request as ready for review December 4, 2020 14:26
legander
legander approved these changes Dec 4, 2020
View reviewed changes
Copy link
Collaborator

@legander legander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🥇

@w1kman w1kman merged commit 62746c3 into master Dec 7, 2020
@w1kman w1kman deleted the bug/query-string-params-double-inclusion branch December 7, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legander legander legander approved these changes

@allansson allansson Awaiting requested review from allansson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w1kman @legander