Don't throw on inconsistent content type #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legander
reviewed
Dec 11, 2020
allansson
force-pushed
the
feat/dont-throw-on-inconsistent-content-type
branch
from
4fc3957
to
874259b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When postData.mimeType and Content-Type headers were not equal, the har-to-k6 converter threw "Inconsistent post content type (0): 'text/plain' vs 'application/x-www-form-urlencoded'."
This causes many recordings or HAR imports to fail because many applications out in the wild don't follow/care about standards.
New behavior
Inconsistency is still recognized, but instead of throwing an
InvalidArchiveError, it is logged viaconsole.warn