Feat/use formdata multipart #67
Conversation
|
|
||
| function generateAppendData(params) { | ||
| return Array.from(params).reduce((acc, [name, valueSet]) => { | ||
| valueSet.forEach((value) => { |
There was a problem hiding this comment.
Nit, would be nicer to use map instead of forEach :)
Array.from(params).reduce((rows, [name, valueSet]) => [
...rows,
Array.from(set).map((value) => {
return line
})
], [])
There was a problem hiding this comment.
yup, good catch
| { | ||
| "fileName": "jpeg-quality-30.jpg", | ||
| "name": "file", | ||
| "value": "data:image/jpeg;base64,/9j/4AAQSkZJRgABAQEBLAEsAAD/2wBDABsSFBcUERsXFhceHBsgKEIrKCUlKFE6PTBCYFVlZF9VXVtqeJmBanGQc1tdhbWGkJ6jq62rZ4C8ybqmx5moq6T", |
There was a problem hiding this comment.
Technically, this wouldn't be a data-uri. It's kind of redundant. But it doesn't really matter and I guess you could send a data-uri in a multipart body.
| @@ -53,6 +56,7 @@ function addBoundary(boundary, headers) { | |||
| return item | |||
| }) | |||
|
|
|||
| headers.delete('Content-Type') // Remove uppercased content-type in case it exists | |||
There was a problem hiding this comment.
I cannot help but feel that this should be part of some kind of general sanitizing/normalization phase. Feels like we are doing this in other places as well?
There was a problem hiding this comment.
You're right, there are some inconsistencies between how the headers are being set (lower-cased or upper-cased). In this case that caused a bug under certain circumstances.
There was a problem hiding this comment.
Agree with @allansson , there should be normalization of the incoming headers in the parse stage really. Although I think this can be a future improvement for the sake of getting this one out 👍
There was a problem hiding this comment.
I agree. Was just something I thought about when I saw it. :)
Change how we generate
multipart/form-datapayloads:Fixes #56