Feat/normalize with add sleep (CLI --add-sleep) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
requested changes
Mar 15, 2021
legander
reviewed
Mar 15, 2021
legander
reviewed
Mar 16, 2021
legander
reviewed
Mar 16, 2021
legander
reviewed
Mar 16, 2021
legander
reviewed
Mar 16, 2021
|
Have run some testing now, both from CLI and from the Test builder in the cloud app. It works nicely! I think we can round the sleeps to 1 precision point, then its OK from me 🙄 |
- no "by reference" - sleep rounded to one decimal (instead of two) - Remove "draft" - no "delete" - early check of entry.startedDateTime
legander
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize input HAR (with or without added
sleep())Background
As the HAR spec does not enforce the order of entries to be meaningful, order need to be sorted for the resulting script to resemblance the events that took place in order to produce the HAR.
Another missing piece is the time between requests. Currently
sleep()need to be added manually after the conversion to script.Sort
Sorting is done automatically as long as every entry has a
startedDateTimethat is notNaNwhen parsing withDateIf at least one entry is missing
startedDateTime, the initial input archive will be returned.Add sleep
When
--add-sleepis passed to the CLI (or{ addSleep: true }is passed as second parameter toliHARToK6Script/normalizeHAR), LI-HAR sleep objects will be added to entries if;CLI
--add-sleepoption has been added to CLI. Default: falseliHARToK6Script
liHARToK6Scriptcan be called with options as the second parameter.To add sleep between request:
liHARToK6Script(har, { addSleep: true })(new) normalizeHAR
If you only want to "normalize" the HAR (without creating a k6 script), you can run
normalizeHAR(har, { addSleep: true })