[fix] remove verror dependency from lib code #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
commented
Oct 18, 2021
src/error.js
Outdated
Comment on lines
1
to
9
| class DetailedError extends Error { | ||
| constructor(details, message) { | ||
| super(typeof details === 'string' ? details : message) | ||
|
|
||
| class HarToK6Error extends VError {} | ||
| class InvalidArchiveError extends HarToK6Error {} | ||
| class UnrecognizedError extends HarToK6Error {} | ||
| if (typeof details === 'object') { | ||
| Object.assign(this, details) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This error mimics the verror options object. We pass a name to the error for extra detail. I wasn't 100% certain that we always passed that object though, so I added some type checking for extra safety.
There was a problem hiding this comment.
We pass { name: string } in every call to InvalidArchiveError and UnrecognizedError.
allansson
commented
Oct 18, 2021
Comment on lines
+9
to
+11
| const { VError } = require('verror') | ||
|
|
||
| class CommandLineError extends HarToK6Error {} | ||
| class CommandLineError extends VError {} |
There was a problem hiding this comment.
We only care about the added functionality from verror when it's a CommandLineError, so I just moved the dependency up here.
w1kman
previously approved these changes
Oct 29, 2021
w1kman
reviewed
Oct 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verrorpackage used insrc/errors.jshas a dependency on node built-in modules, which means that the library code requires a bunch of node-polyfills to work in the browser. This PR removes that dependency by only using theverrormodule inbin/har-to-k6.