Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Extend variable RegExp (still pretty lose, but not uber lose) #90

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[fix] Extend variable RegExp (still pretty lose, but not uber lose) #90

merged 1 commit into from
Nov 17, 2021

Conversation

w1kman
Copy link
Contributor

@w1kman w1kman commented Nov 17, 2021

Updated RegExp for variable recognition, to avoid some unintentional matches in eg binary strings

legander
legander approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@legander legander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@w1kman w1kman merged commit a8c3510 into master Nov 17, 2021
@w1kman w1kman deleted the fix/better-variable-avoidance branch November 17, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legander legander legander approved these changes

@EdvinasDaugirdas EdvinasDaugirdas Awaiting requested review from EdvinasDaugirdas

@allansson allansson Awaiting requested review from allansson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w1kman @legander