Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

har-to-k6 Feat/error improvements #93

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Conversation

EdvinasDaugirdas
Copy link
Contributor

@EdvinasDaugirdas EdvinasDaugirdas commented Dec 8, 2021

Clean up InvalidArchiveError error messages and extend with two properties:

  • path: specifies the full path where the validation error has happened
  • indexes: specifies the indexes where the validation error has happened

Example from CLI:

Before:

Screenshot 2021-12-08 at 13 54 00

After:

Screenshot 2021-12-08 at 13 45 26


Example from programmatic use:

Before:

Screenshot 2021-12-08 at 13 53 29

After:

Screenshot 2021-12-08 at 13 50 06

@EdvinasDaugirdas EdvinasDaugirdas requested review from w1kman, allansson and legander and removed request for w1kman December 8, 2021 15:01
@sniku sniku changed the title Feat/error improvements har-to-k6 Feat/error improvements Mar 9, 2022
@sniku sniku added the frontend label Mar 9, 2022
Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPlainObject is pretty strict. I stumbled upon the "... must be an Object" error and had a WTF-moment when I indeed passed an Object.

non-negative is more readable and arguably a more correct form of nonnegative.

src/validate/cookies.js Outdated Show resolved Hide resolved
src/validate/checks.js Outdated Show resolved Hide resolved
src/validate/entries.js Outdated Show resolved Hide resolved
src/validate/entry.js Outdated Show resolved Hide resolved
src/validate/headers.js Outdated Show resolved Hide resolved
src/validate/sleep.js Outdated Show resolved Hide resolved
src/validate/sleep.js Outdated Show resolved Hide resolved
src/validate/sleep.js Outdated Show resolved Hide resolved
src/validate/variable.js Outdated Show resolved Hide resolved
src/validate/variables.js Outdated Show resolved Hide resolved
@EdvinasDaugirdas
Copy link
Contributor Author

@w1kman agree with your suggestions. Updated the PR accordingly.

Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EdvinasDaugirdas EdvinasDaugirdas merged commit 6bf68cd into master Jun 14, 2022
@EdvinasDaugirdas EdvinasDaugirdas deleted the feat/error-improvements branch June 14, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants