-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
har-to-k6 Feat/error improvements #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPlainObject
is pretty strict. I stumbled upon the "... must be an Object" error and had a WTF-moment when I indeed passed an Object.
non-negative
is more readable and arguably a more correct form of nonnegative
.
@w1kman agree with your suggestions. Updated the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Clean up
InvalidArchiveError
error messages and extend with two properties:path
: specifies the full path where the validation error has happenedindexes
: specifies the indexes where the validation error has happenedExample from CLI:
Before:
After:
Example from programmatic use:
Before:
After: