[loki] feat: Add optional prometheusRule value/template #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyenx
force-pushed
the
feat/add-prometheus-rules-for-loki
branch
2 times, most recently
from
28858ee
to
d8f750b
Compare
zanhsieh
changed the title
|
@eyenx |
zanhsieh
approved these changes
Feb 18, 2022
zanhsieh
requested changes
Feb 18, 2022
eyenx
force-pushed
the
feat/add-prometheus-rules-for-loki
branch
from
700943b
to
b88161c
Compare
eyenx
requested review from
maorfr,
torstenwalter and
Xtigyro
as code owners
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
eyenx
force-pushed
the
feat/add-prometheus-rules-for-loki
branch
from
b88161c
to
3cd2765
Compare
zanhsieh
approved these changes
Feb 19, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional prometheusRule template for adding custom Rules which can be used by alertmanager to alert us.
It makes sure prometheusRules are only deployed if serviceMonitor is enabled
Signed-off-by: Toni Tauro toni.tauro@adfinis.com