Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] fix broken interpolation for notifier searchNamespace in grafana chart #2045

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[grafana] fix broken interpolation for notifier searchNamespace in grafana chart #2045

merged 1 commit into from
Dec 7, 2022

Conversation

muhlba91
Copy link
Contributor

@muhlba91 muhlba91 commented Dec 6, 2022

the condition for the searchNamespaces interpolation when enabling the notifiers sidecar was incorrect after the 6.44.0 migration.
hence, the interpolation {{ tpl (. | join ",") $root }} did not succeed as . was the entire pod context.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@muhlba91 muhlba91 changed the title fix: fix interpolation for notifier searchNamespace in grafana chart [grafana] fix interpolation for notifier searchNamespace in grafana chart Dec 6, 2022
@muhlba91 muhlba91 changed the title [grafana] fix interpolation for notifier searchNamespace in grafana chart [grafana] fix broken interpolation for notifier searchNamespace in grafana chart Dec 6, 2022
@zanhsieh
Copy link
Collaborator

zanhsieh commented Dec 7, 2022

@muhlba91
Thank you for the contribution. Could you bump the version in Chart.yaml to latest?

Signed-off-by: Daniel Muehlbachler-Pietrzykowski <daniel@muehlbachler.io>
@muhlba91
Copy link
Contributor Author

muhlba91 commented Dec 7, 2022

@zanhsieh done. i bumped it to 6.45.2. 😃

@zanhsieh zanhsieh merged commit dca92e8 into grafana:main Dec 7, 2022
@ikogan
Copy link

ikogan commented Dec 7, 2022

Works for me as well! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants