[enterprise-metrics] Remove consul references with lint change fixed + DCO signed. #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jennifer Villa <jen.villa@grafana.com>
Signed-off-by: Jennifer Villa <jen.villa@grafana.com>
Signed-off-by: Jennifer Villa <jen.villa@grafana.com> Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
force-pushed
the
remove_consul_2
branch
from
f3a3031
to
80ff311
Compare
jdbaldry
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM thanks for the contribution!
In case you are interested in the steps needed to get this PR passing linting:
- I rebased on main using
$ git fetch; git rebase -i origin/main - I fixed up the the chart version bump and changelog entry commit to use 1.5.2
- I fixed up the exports commit to use the v1.5.2 chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Removing references to Consul in yaml files since GEM is focusing on memberlist.
Solves:
#581
Original PR was here
https://github.com/grafana/helm-charts/pull/655/commits
but I created a new one to make sure DCO was signed and linting passed.