[enterprise-logs] Run GEL as non-root user enterprise-logs
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbaldry
reviewed
Sep 20, 2021
| @@ -42,8 +42,10 @@ spec: | |||
| priorityClassName: {{ .Values.adminApi.priorityClassName }} | |||
| {{- end }} | |||
| securityContext: | |||
| {{- toYaml .Values.adminApi.securityContext | nindent 8 }} | |||
| fsGroup: 10001 | |||
There was a problem hiding this comment.
If I understand this correctly, this affects all containers in the Pod but I guess minio is fine with this as its user can still read the configuration that is mounted in. We need the Pod level SecurityContext to support the volumeMounts in the AdminAPI container because the Container SecurityContext doesn't affect the Pod Volumes.
There was a problem hiding this comment.
Right. fsGroup is only supported on the Pod spec, but not on container level. Since minio runs as root, this is ok.
This is needed when running GEL as AWS Marketplace container product on EKS where the users needs access to the EKS service account token. Fixes #687 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/run-as-non-root
branch
from
589bd35
to
a736998
Compare
|
@jdbaldry rebased with |
vlad-diachenko
approved these changes
Sep 22, 2021
jdbaldry
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains PR #684 and therefore needs to be rebased after that is merged.
Fixes #687