[grafana] Improve sidecar.enableUniqueFilenames description #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Luder <maser@winterfell.ch>
maser
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
@maser |
zanhsieh
changed the title
Signed-off-by: Martin Luder <maser@winterfell.ch>
|
@zanhsieh I bumped it. |
zanhsieh
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just ran into the issue of two secrets containing the same filename and it took us forever to figure out that this was the reason why one of the data sources wasn't showing up in Grafana.
I think the
sidecar.enableUniqueFilenamesdescription could be clearer on what its effect is. I added a suggestion based on thekiwigrid/k8s-sidecardocumentation of the environment variable.I think enabling unique filenames by default would also make sense. We found the behavior of silently overwriting the files very confusing and if unique filenames were enabled by default we wouldn't even have run into the problem. Are there any reasons to keep it disabled?