-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo] Add overrides to Tempo #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the PR will need a helm charts version bump.
Also can you please fix the docs with
docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.4.0
Done fixing the docs. I am not sure if the version requires a bump since the PR is very recent. |
Oh, no every change requires a bump so the latest changes will be available with the next release |
bumped to 0.12.1 is that right? |
Thanks for your patience @gabrieloandco. You will have to run the docs update again after updating the version number.
And also Ci requires that you sign the commits. |
I've opened a new PR with the required changes as we were going back and forth a bit. Your commits have been squashed and signed. Let me know if that works! |
Yes that would be perfect, sorry for the inconveniences first PR I do on this project. |
No worries, its all good. :) In general I would recommend looking at the CI failures and working backwards to figure out what needs to be fixed. Thanks for your contribution! |
We needed to add overrides to Tempo to change some configurations.