Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] Add overrides to Tempo #871

Closed
wants to merge 4 commits into from
Closed

[tempo] Add overrides to Tempo #871

wants to merge 4 commits into from

Conversation

gabrieloandco
Copy link
Contributor

We needed to add overrides to Tempo to change some configurations.

@zanhsieh zanhsieh changed the title Add overrides to Tempo [tempo] Add overrides to Tempo Dec 2, 2021
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the PR will need a helm charts version bump.

Also can you please fix the docs with

docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.4.0

@gabrieloandco
Copy link
Contributor Author

Thanks, the PR will need a helm charts version bump.

Also can you please fix the docs with

docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.4.0

Done fixing the docs. I am not sure if the version requires a bump since the PR is very recent.

@annanay25
Copy link
Contributor

Oh, no every change requires a bump so the latest changes will be available with the next release
https://github.com/grafana/helm-charts/runs/4394359506?check_suite_focus=true

@gabrieloandco
Copy link
Contributor Author

Oh, no every change requires a bump so the latest changes will be available with the next release https://github.com/grafana/helm-charts/runs/4394359506?check_suite_focus=true

bumped to 0.12.1 is that right?

@annanay25
Copy link
Contributor

Thanks for your patience @gabrieloandco. You will have to run the docs update again after updating the version number.

docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.4.0

And also Ci requires that you sign the commits.

@annanay25
Copy link
Contributor

I've opened a new PR with the required changes as we were going back and forth a bit. Your commits have been squashed and signed. Let me know if that works!

@gabrieloandco
Copy link
Contributor Author

I've opened a new PR with the required changes as we were going back and forth a bit. Your commits have been squashed and signed. Let me know if that works!

Yes that would be perfect, sorry for the inconveniences first PR I do on this project.

annanay25 added a commit that referenced this pull request Dec 3, 2021
[tempo] Add overrides to Tempo
@annanay25
Copy link
Contributor

No worries, its all good. :)

In general I would recommend looking at the CI failures and working backwards to figure out what needs to be fixed.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants