[grafana] fix: dont get admin credentials from secret if admin is not enabled #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitnik
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
bitnik
changed the title
bitnik
changed the title
|
This just hit me as well. Any eta when |
zanhsieh
previously approved these changes
Dec 15, 2021
|
@bitnik |
Signed-off-by: Kenan Erdogan <kenanerdogan@gmail.com>
|
@zanhsieh I bump it to latest, but now it requires a new review and then I can check the "lint-test". |
zanhsieh
approved these changes
Dec 16, 2021
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since grafana chart v6.19.0, deployment is failing with
Error: secret "prometheus-stack-grafana" not foundwhen admin user is disabled (withGF_SECURITY_DISABLE_INITIAL_ADMIN_CREATION) and sidecar.datasources is enabled.