[grafana] Allowing older version of Kubernetes (<1.13) to use the latest versio… #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pburgisser
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
pburgisser
force-pushed
the
make_enableservicelinks_optional
branch
2 times, most recently
from
b4329b7
to
4b6cbbd
Compare
pburgisser
changed the title
…n of the chart by making the pod parameter enableServiceLinks optional. Fix grafana#669 Signed-off-by: Philippe Bürgisser <philippe.burgisser@camptocamp.com> Signed-off-by: Philippe <philippe.burgisser@camptocamp.com>
pburgisser
force-pushed
the
make_enableservicelinks_optional
branch
from
4b6cbbd
to
63e80bd
Compare
zanhsieh
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing older version of Kubernetes (<1.13) to use the latest version of the chart by making the pod parameter enableServiceLinks optional.
Fix #669
Signed-off-by: Philippe Bürgisser philippe.burgisser@camptocamp.com
I didn't use the helm built-in object Capabilities.KubeVersion as is always return version 1.18 on a OpenShift 3.11 which is based on Kubernetes version 1.11 and the enableServiceLinks is available since Kube 1.13