Add logging and metrics #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrieedwards
force-pushed
the
cedwards/add-logs-and-metrics
branch
from
634ea7f
to
4b03255
Compare
carrieedwards
force-pushed
the
cedwards/add-logs-and-metrics
branch
from
5e354ee
to
58ef2ab
Compare
ywwg
requested changes
Mar 4, 2022
ywwg
approved these changes
Mar 14, 2022
| expMetrics: ` | ||
| # HELP influxdb_proxy_ingester_data_conversion_seconds Time (in seconds) spent converting ingested InfluxDB data into Prometheus data. | ||
| # TYPE influxdb_proxy_ingester_data_conversion_seconds histogram | ||
| influxdb_proxy_ingester_data_conversion_seconds_bucket{le="0.005"} 0 |
There was a problem hiding this comment.
Do we need to set some labels? I am not sure how that works, but we want to make sure the metrics get tagged with the hostname and cluster, etc. That's normally part of the Registerer I think? Can you make a change in the test so a label gets applied to these metrics so we can confirm that works?
There was a problem hiding this comment.
I confirmed that the namespace and cluster labels are added at a later point, so they wouldn't be added for the unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics and logging to the influx2cortex proxy.