Use remotewrite API #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
requested changes
Mar 18, 2022
There was a problem hiding this comment.
Nice work @carrieedwards added a few small things 👍
I'm also missing some CI linting using golangci-lint. The sooner we add it to drone the less things we're going to have to fix later on.
ywwg
requested changes
Mar 18, 2022
ywwg
previously approved these changes
Mar 18, 2022
jesusvazquez
previously approved these changes
Mar 18, 2022
carrieedwards
force-pushed
the
cedwards/use-remote-write-api
branch
from
de00de8
to
5ecb28f
Compare
ywwg
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of an internal GRPC server and replaces it with the remotewrite API for handling requests.