Clean up error handling #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwg
commented
Mar 18, 2022
| @@ -73,7 +73,7 @@ func influxPointToTimeseries(pt models.Point) ([]cortexpb.TimeSeries, error) { | |||
|
|
|||
| fields, err := pt.Fields() | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error getting fields from point: %w", err) | |||
| return nil, errorx.Internal{Msg: "error getting fields from point", Err: err} | |||
There was a problem hiding this comment.
I am not exactly sure what kind of error this is, but it seems like an internal, not a client error.
ywwg
force-pushed
the
owilliams/error-handling
branch
from
12ab71b
to
abc6f9d
Compare
carrieedwards
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All <500 errors should only be info-logged because they are expected and not a problem for the operation of the server. >=500s are warnings because they are trouble, but do not represent unrecoverable server errors.
Note that we are returning error contents into the http error. We should make sure that there's no chance that internal error details might get returned to clients. I don't think that is a possibility but we should spot-check as development continues to make sure