Add internal label for tracking active series #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/influx/parser.go
Outdated
| lbls = append(lbls, cortexpb.LabelAdapter{ | ||
| Name: labels.MetricName, | ||
| Value: name, | ||
| }) | ||
| lbls = append(lbls, cortexpb.LabelAdapter{ | ||
| Name: "_original_format", |
There was a problem hiding this comment.
Suggested change
| Name: "_original_format", | |
| Name: "__original_source__", |
I'd rename this label to __original_source__ for a few reasons:
- An internal label in Prometheus is actually prefixed by two underscores. The suffix just makes it more regular with the others like
__name__. - Although we're thinking of this label as "internal" its not actually internal because its not recognized by prometheus or cortex themselves. That said we could actually upstream this change to cortex, since there will be other proxies translating from other sources. So we can make this an internal label recognized by cortex and then the translators can just import the label. No need to do this now but could be a great idea when there are other translators available.
- I prefer
sourceoverformatbecause to me its more natural to refer to influx as a source database rather than a metric format.
There was a problem hiding this comment.
And since this is going to be an important tag, we should define the string as a constant somewhere rather than as an inline literal
There was a problem hiding this comment.
I was part of the offline discussion before the initial comment was made, but thinking about it more, I think __proxy_source__ would be better. original doesn't add much information to the label name, but source by itself seems too generic.
There was a problem hiding this comment.
I think proxy_source is good. I will update it.
carrieedwards
force-pushed
the
cedwards/add-internal-label
branch
from
e28848e
to
74da19d
Compare
|
Go coverage report:
|
|
Go coverage report:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an internal label to all metrics parsed by the proxy before being written to cortex. This internal label will be used for tracking the number of active series.