Add and use server package

[carrieedwards]

This PR adds and uses a server package to handle the requests.

[ywwg]

mostly some cleanup we need to do

[ywwg]

lint report has some items

[ywwg]

very nice! Just one minor nit

[carrieedwards]

For the linting report, is it necessary to check the error value of the logger?

[leizor]

For the linting report, is it necessary to check the error value of the logger?

I've been prepending those lines with _ = (basically throwing away the result still, but doing it explicitly so the linter is happy).

[ywwg]

I wonder if we can tweak the linter to ignore log return values specifically without having to do either this or a //nolint comment? This is annoying to have to do. There's an exhausting discussion here: go-kit/kit#164

[ywwg]

"""
If, when using Go kit, you want to ensure all logging errors are handled in some way then I believe the correct approach is to write a Logger decorator that handles errors returned by a wrapped logger as desired.
"""

[ywwg]

so it seems that we should create an adapter layer that deals with (ignores) the errors so we don't have to hack the call site to satisfy the linter. Example: go-kit/kit#164 (comment)

[carrieedwards]

Should I try to fix the linting in a separate PR?

[ywwg]

you should at least fix the dead code lint, but yeah we can address the logging lint later

[ywwg]

and you do want to check the value of server.Run, like:

go func() {
if err := server.Run() ;err != nil {...}
}()

[grafanabot]

Go coverage report:

Click to expand.

File	%
github.com/grafana/influx2cortex/pkg/errorx/errors.go	67.3%
github.com/grafana/influx2cortex/pkg/errorx/http_translator.go	100.0%
github.com/grafana/influx2cortex/pkg/influx/api.go	90.0%
github.com/grafana/influx2cortex/pkg/influx/errors.go	100.0%
github.com/grafana/influx2cortex/pkg/influx/parser.go	84.1%
github.com/grafana/influx2cortex/pkg/influx/recorder.go	91.7%
github.com/grafana/influx2cortex/pkg/remotewrite/client.go	69.1%
github.com/grafana/influx2cortex/pkg/remotewrite/measured_client.go	88.9%
github.com/grafana/influx2cortex/pkg/remotewrite/recorder.go	100.0%
github.com/grafana/influx2cortex/pkg/route/registerer.go	100.0%
github.com/grafana/influx2cortex/pkg/server/middleware/http_auth.go	0.0%
github.com/grafana/influx2cortex/pkg/server/middleware/http_fake_auth.go	0.0%
github.com/grafana/influx2cortex/pkg/server/middleware/instrument.go	6.7%
github.com/grafana/influx2cortex/pkg/server/middleware/logging.go	69.7%
github.com/grafana/influx2cortex/pkg/server/middleware/middleware.go	0.0%
github.com/grafana/influx2cortex/pkg/server/middleware/request_limits.go	81.8%
github.com/grafana/influx2cortex/pkg/server/middleware/response.go	57.1%
github.com/grafana/influx2cortex/pkg/server/middleware/route_matcher.go	0.0%
github.com/grafana/influx2cortex/pkg/server/middleware/tracer.go	13.0%
github.com/grafana/influx2cortex/pkg/server/server.go	83.3%
github.com/grafana/influx2cortex/pkg/tenant/resolver.go	75.6%
github.com/grafana/influx2cortex/pkg/tenant/tenant.go	91.7%
github.com/grafana/influx2cortex/pkg/util/bytereplacer/byte_replacer.go	100.0%
github.com/grafana/influx2cortex/pkg/util/extract_forwarded.go	66.7%
github.com/grafana/influx2cortex/pkg/util/http.go	68.3%
github.com/grafana/influx2cortex/pkg/util/log/experimental.go	0.0%
github.com/grafana/influx2cortex/pkg/util/log/log.go	0.0%
github.com/grafana/influx2cortex/pkg/util/log/rate_limit.go	90.0%
github.com/grafana/influx2cortex/pkg/util/log/wrappers.go	0.0%
github.com/grafana/influx2cortex/pkg/util/push/push.go	60.0%
total	65.5%

Go lint report:

Click to expand.

pkg/server/server.go:155:24: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
		level.Info(s.log).Log("msg", "Starting http server", "addr", s.httpListener.Addr().String())
		                     ^
pkg/server/server.go:165:24: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
		level.Info(s.log).Log("msg", "Starting grpc server", "addr", s.grpcListener.Addr().String())
		                     ^
pkg/server/server.go:182:23: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
	level.Info(s.log).Log("msg", "Shutting down http server")
	                     ^

[ywwg]

thanks! good work importing this raft of packages