Code cleanup and refactoring #43
Merged
+103
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ywwg
commented
Apr 5, 2022
•
ywwg
commented
- Add support for handling SIGTERM signal
- Refactor Run function into api module instead of binary so it can be called from e2e tests without needing to start up the binary itself.
- Add wrappers for error and warning logging so we don't need to keep ignoring the return value
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
I think the sigterm handling needs to change a bit if we use the pkg/server instead of the weaveworks/common server, since pkg/server doesn't have its own SignalHandler interface |
|
ok I'll update after your change goes in |
This comment has been minimized.
This comment has been minimized.
|
hand-tested on the command line, works |
This comment has been minimized.
This comment has been minimized.
leizor
previously approved these changes
Apr 6, 2022
| // Error logs an error and panics if the log call itself had an error. | ||
| func Error(logger log.Logger, keyvals ...interface{}) { | ||
| if err := level.Error(logger).Log(keyvals); err != nil { | ||
| panic(fmt.Sprintf("error writing to log: %v", err)) |
There was a problem hiding this comment.
Just curious - why %v and not %w?
There was a problem hiding this comment.
actually I can't! %w is only supported in fmt.Errorf
|
oh hm %w doesn't work in sprintf |
|
looks like I broke tests so I'll do that after lunch |
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.