Add /metrics endpoint #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizor
force-pushed
the
leizor/query-squad/issue-114
branch
2 times, most recently
from
93be500
to
13e47af
Compare
This comment has been minimized.
This comment has been minimized.
leizor
force-pushed
the
leizor/query-squad/issue-114
branch
from
13e47af
to
93310de
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
leizor
force-pushed
the
leizor/query-squad/issue-114
branch
from
8470ec6
to
da8a887
Compare
This comment has been minimized.
This comment has been minimized.
fionaliao
reviewed
Apr 12, 2022
ywwg
reviewed
Apr 12, 2022
ywwg
reviewed
Apr 12, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ywwg
requested changes
Apr 12, 2022
| _, _ = w.Write([]byte("ok")) | ||
| })) | ||
|
|
||
| httpServer := &http.Server{ |
There was a problem hiding this comment.
does this mean the binary has two http servers (the api and the internalserver)? That's a little weird but I can see why we might do it that way. Though that means we need to make sure the /metrics call is going to the correct port vs the write calls. (Not sure where promscrape is configured)
There was a problem hiding this comment.
Yep! I figured out how to do it yesterday, so I'll have a follow-up PR to get that fixed once this gets merged.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
leizor
force-pushed
the
leizor/query-squad/issue-114
branch
from
f444d7f
to
21e2e88
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
ywwg
reviewed
Apr 12, 2022
| flags.Int64Var(&cfg.HTTPMaxRequestSizeLimit, prefix+"server.http-max-req-size-limit", defaultHTTPRequestSizeLimit, "HTTP max request body size limit. Defaults to 10 mb.") | ||
| flags.StringVar(&cfg.HTTPListenAddress, prefix+"server.http-listen-address", "0.0.0.0", "Sets listen address for the http server") | ||
| flags.IntVar(&cfg.HTTPListenPort, prefix+"server.http-listen-port", defaultListenPort, "Sets listen address port for the http server") | ||
| flags.IntVar(&cfg.HTTPConnLimit, prefix+"server.http-listen-conn-limit", 0, "Sets a limit to the amount of http connections, 0 means no limit") |
There was a problem hiding this comment.
nice, thanks for these updates
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "internal" server that defaults to listening on port 8081 and provides two endpoints:
/metrics: Prometheus metrics endpoint/healthz: A health check endpoint