Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packages from mimir-proxies #66

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Conversation

alexgreenbank
Copy link
Contributor

@alexgreenbank alexgreenbank commented Aug 11, 2022

Removes appcommon, server, remotewrite and some util packages from influx2cortex and uses the versions in mimir-proxies or (for util packages) mimir instead.

Also converts code to use mimirpb instead of cortexpb.

Corresponding PR in mimir-proxies repo may follow with a few small changes, this will contain details of cross-repo diffs: grafana/mimir-proxies#6

@alexgreenbank alexgreenbank added the enhancement New feature or request label Aug 11, 2022
@alexgreenbank alexgreenbank requested a review from a team August 11, 2022 07:25
@grafanabot

This comment has been minimized.

@grafanabot

This comment has been minimized.

1 similar comment
@grafanabot

This comment has been minimized.

@grafanabot
Copy link

Go coverage report:

Click to expand.
File %
github.com/grafana/influx2cortex/pkg/errorx/errors.go 67.3%
github.com/grafana/influx2cortex/pkg/errorx/http_translator.go 100.0%
github.com/grafana/influx2cortex/pkg/influx/api.go 93.3%
github.com/grafana/influx2cortex/pkg/influx/errors.go 100.0%
github.com/grafana/influx2cortex/pkg/influx/parser.go 84.7%
github.com/grafana/influx2cortex/pkg/influx/proxy.go 61.9%
github.com/grafana/influx2cortex/pkg/influx/recorder.go 91.7%
github.com/grafana/influx2cortex/pkg/route/registerer.go 100.0%
github.com/grafana/influx2cortex/pkg/tenant/resolver.go 75.6%
github.com/grafana/influx2cortex/pkg/tenant/tenant.go 91.7%
github.com/grafana/influx2cortex/pkg/util/extract_forwarded.go 66.7%
github.com/grafana/influx2cortex/pkg/util/http.go 0.0%
github.com/grafana/influx2cortex/pkg/util/log/log.go 0.0%
github.com/grafana/influx2cortex/pkg/util/log/rate_limit.go 90.0%
github.com/grafana/influx2cortex/pkg/util/log/wrappers.go 0.0%
total 60.4%

Go lint report:

No issues found. 😎

Copy link
Contributor

@leizor leizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@alexgreenbank alexgreenbank merged commit 9fc9a35 into main Aug 15, 2022
@alexgreenbank alexgreenbank deleted the alexg/mimir-packages-1 branch August 15, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants